This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Draft Istanbul Support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first time dealing with this library's code, so I may be missing something, but the only thing that caught my attention is that this PR modifies all the chains' jsons except for kovan's. |
|
@alcuadrado Thanks for having a look! When I created the library I didn't find the block numbers for HFs for the Kovan testnet, so I left this out. You can add these, but this should be addressed in a separate PR. Can you or someone else approve of nothing else missing? |
s1na
approved these changes
May 27, 2019
Merged
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to release this as
v1.2.0(could technically be alsov1.1.xbut then it becomes more transparent where Istanbul integration is prepared in other libraries) and then do subsequent parameter additions asv1.2.xreleases.This is mainly that we have a clear
IstanbulHF switch for the VM and can start implementations around ethereumjs/ethereumjs-monorepo#501 with ethereumjs/ethereumjs-monorepo#519 eventually as a first implementation target.