Updates difficulty calculation per EIP PR 1240 #710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EIP number TBD, will update once decided. ethereum/EIPs#1240
|
@MicahZoltu Do you want to keep this around? This would require a fork. The current It's fine to keep this PR around for as long as the EIP is in Draft in case it gets Accepted and included in a fork, but for now I don't expect to merge it. |
|
I'm somewhat ambivalent to closing this or keeping it open. I believe I was outvoted for this change, so perhaps I should just close the PR as well (even though I still think it is a good idea). |
|
Then I'd recommend to close it for now and create a new PR into a branch for the fork in which it will be included. |
|
Closing since EIP-1240 hasn't been accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP number TBD, will update once decided.
ethereum/EIPs#1240