Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly combine address and contract address list in event filter param construction #3618

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Aerilym
Copy link

@Aerilym Aerilym commented Feb 16, 2025

What was wrong?

Related to Issue #3617
Closes #3617

How was it fixed?

See description of #3617

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@Aerilym
Copy link
Author

Aerilym commented Feb 16, 2025

Put a lot of details in the issue #3617 happy to expand on it or add more to this contribution. This just fixed my issue for what I'm doing so thought I'd get the ball rolling

@Aerilym
Copy link
Author

Aerilym commented Feb 16, 2025

I made a change to make sure the final output works if you have address and/or contract_address as a list or string. Also de-duplicated but just using address if they're the same. Also had to do some gymnastics to get the linter to like the type hints, not sure if that resulted in the best solution.

@Aerilym
Copy link
Author

Aerilym commented Feb 16, 2025

The linting is still unhappy, would love some direction on how you want the type hinting to work in this section? as there is no type assertion in if blocks it seems overly strict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

construct_event_filter_params improperly formats addresses as lists of lists
1 participant