Add comprehensive transaction signing tests #3587
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Date and Time (UTC - YYYY-MM-DD HH:MM:SS formatted): 2025-01-24 15:41:11
Current User's Login: iradukun
What was wrong?
The ethereum-tester provider was missing implementations for transaction signing test methods. Specifically, the following methods were marked as
not_implemented
:test_eth_sign_transaction_legacy
test_eth_sign_transaction
test_eth_sign_transaction_hex_fees
Related to Issue #
This implementation addresses the
not_implemented
methods in theTestEthereumTesterEthModule
class.How was it fixed?
Added comprehensive test implementations for transaction signing methods:
Added
test_eth_sign_transaction_legacy
:Added
test_eth_sign_transaction
:Added
test_eth_sign_transaction_hex_fees
:The implementation follows project testing patterns and includes proper assertions for type checking and transaction validation.
Todo:
Cute Animal Picture
Release Notes Entry: