Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance of an account post SELFDESTRUCT #1170

Closed
wants to merge 12 commits into from

Conversation

qbzzt
Copy link
Collaborator

@qbzzt qbzzt commented Feb 27, 2023

Immediately after SELFDESTRUCT the balance is zero
When called again (in the same transaction), the value seems to disappear

When called again in a following transaction, the value causes the address to be reborn

Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the suicide logic

balance: 10
code: |
:yul {
selfdestruct(0x1000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end this is much more readable then the suicide contract with complex selector logic in statetest

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it can't check things such as "SELFDESTRUCT(dst1) the first time you're called, SELFDESTRUCT(dst2) the second time" without additional logic.

@qbzzt qbzzt requested a review from winsvega March 1, 2023 02:15
@winsvega
Copy link
Collaborator

winsvega commented Mar 3, 2023

src/README vector description?

@qbzzt
Copy link
Collaborator Author

qbzzt commented Mar 6, 2023

src/README vector description?

Added. No added test vectors because they are also checked by other tests.

@winsvega
Copy link
Collaborator

winsvega commented Mar 7, 2023

ok now we have too many commits and build check is failing.
did the unfilled tests got merged accidentially ?

@qbzzt qbzzt mentioned this pull request Mar 10, 2023
@qbzzt
Copy link
Collaborator Author

qbzzt commented Mar 10, 2023

I don't know what is happening, replaced by #1181

@qbzzt qbzzt closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants