Add GET /v2/verify/{verificationId} endpoint
#1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status can be implicitly derived and is not needed for the API response
manuelwedler
force-pushed
the
apiv2-job-endpoint
branch
from
88e3727 to
ac7dab8
Compare
|
Note: We'd need to run the |
marcocastignoli
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Looks great, I have some comments. I also have a doubt regarding "v1" verifications. Do we want to create a "fake" verification jobs also for them?I think it makes sense:
If we don't implement verification_jobs for old APIs, we will have a lot of contracts that don't have verification_jobs information (such as compilation_time). And in general it feels wrong to have this discrepancy in our database. @kuzdogan please leave here also your opinion about this
services/server/src/server/services/storageServices/SourcifyDatabaseService.ts
Show resolved
Hide resolved
|
To summarize our yesterday's discussion, I will add the following fields to the API (also in Stoplight):
|
manuelwedler
added a commit
that referenced
this pull request
Mar 3, 2025
* Move API v2 related methods to bottom of SourcifyDatabaseService
* Remove status column from verification_jobs table
The status can be implicitly derived and is not needed for the API response
* Turn id of verification_jobs table into a uuid
* Add GET /v2/verify/{verificationId} endpoint
* Add tests for get job endpoint
* Add onchain bytecodes to verification_jobs_ephemeral table
* Update API v2 specs
* Make compilation_time a bigint
* Add compilationTime, bytecodes and creatorTransactionHash to GET job response
manuelwedler
added a commit
that referenced
this pull request
Mar 3, 2025
* Move API v2 related methods to bottom of SourcifyDatabaseService
* Remove status column from verification_jobs table
The status can be implicitly derived and is not needed for the API response
* Turn id of verification_jobs table into a uuid
* Add GET /v2/verify/{verificationId} endpoint
* Add tests for get job endpoint
* Add onchain bytecodes to verification_jobs_ephemeral table
* Update API v2 specs
* Make compilation_time a bigint
* Add compilationTime, bytecodes and creatorTransactionHash to GET job response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1831