Implement Compilation tests with 100% coverage #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelwedler
requested changes
Jan 23, 2025
packages/lib-sourcify/test/Compilation/SolidityCompilation.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -112,17 +111,6 @@ export class SolidityCompilation extends AbstractCompilation { | |||
|
|
|||
| const auxdataFromRawRuntimeBytecode = `${runtimeAuxdataCbor}${runtimeCborLengthHex}`; | |||
|
|
|||
| // For some reason the auxdata from raw bytecode differs from the legacyAssembly's auxdata | |||
| if (auxdatasFromCompilerOutput[0] !== auxdataFromRawRuntimeBytecode) { | |||
There was a problem hiding this comment.
Could you explain why we don't need to handle this case anymore?
There was a problem hiding this comment.
This would be a problem of the compiler. I don't think we have to handle this case.
Here we are not checking the auxdata against onchain bytecode, but recompilied bytecode. So the only case in which something like this would happen is if the compiler writes an auxdata in the legacyAssembly that is not the same as the one in the bytecode.
packages/lib-sourcify/test/Compilation/VyperCompilation.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Manuel Wedler <34456797+manuelwedler@users.noreply.github.com>
Co-authored-by: Manuel Wedler <34456797+manuelwedler@users.noreply.github.com>
marcocastignoli
merged commit d1491e1
into
verification-flow-refactoring-main
6 checks passed
kuzdogan
pushed a commit
that referenced
this pull request
Feb 28, 2025
* push vyper tests (still need refactoring) * Implement solidity test to get 100% coverage * Refactor Vyper tests * refactor solidity tests * Update packages/lib-sourcify/src/Compilation/VyperCompilation.ts Co-authored-by: Manuel Wedler <34456797+manuelwedler@users.noreply.github.com> * Update packages/lib-sourcify/test/Compilation/VyperCompilation.spec.ts Co-authored-by: Manuel Wedler <34456797+manuelwedler@users.noreply.github.com> * fix duplicate check --------- Co-authored-by: Manuel Wedler <34456797+manuelwedler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO