Improve platform architecture management for Vyper compiler #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelwedler
changed the title
| if ( | ||
| process.platform === 'darwin' && | ||
| (process.arch === 'x64' || process.arch === 'arm64') | ||
| ) { | ||
| return 'darwin'; | ||
| } | ||
| if (process.platform === 'linux' && process.arch === 'x64') { |
There was a problem hiding this comment.
Did you check anything for windows?
There was a problem hiding this comment.
Yes, I also checked Windows. I ran the file command to check for which architectures the three binary types are.
marcocastignoli
approved these changes
Dec 10, 2024
9 tasks
manuelwedler
added a commit
that referenced
this pull request
Jan 2, 2025
* Only log Vyper downloaded on success * add architecture checks for vyper compiler on mac and improve logging
manuelwedler
added a commit
that referenced
this pull request
Jan 2, 2025
Adds vyper support, here the initial PR: #1760. Below the related tasks: - [x] Review what's stored in the database - [x] ~~Create a common folder for the compilers code used by both lib-sourcify and server (idk if it fits in this new feature, imo yes because it's a lot of duplicated code now that we have also vyper stuff)~~ postponed - [x] Rewrite platform architecture management (vyper versions for x86, arm, ...): #1776 - [x] Update READMEs #1786 - [x] Update documentation sourcifyeth/docs#27 - [x] Handle vyper transformations: #1783 - [x] Add more tests, and finalize lib-sourcify test: #1781 - [x] Finalize `/verify/vyper` API errors + openapi responses: #1774 - [x] Check Vyper immutable field to see if we can support immutable transformation: #1790 After merging: - publish new docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated which architectures the binaries are built for. I only had to add a check for Mac binary. I also improved the logging a bit because it was confusing when I tried to run a vyper verification.