Building release on Windows #9476
Conversation
christianparpart
force-pushed
the
windows-tests
branch
30 times, most recently
from
fd19912 to
a2fa30d
Compare
chriseth
force-pushed
the
windows-tests
branch
9 times, most recently
from
bd4d733 to
2f1fafa
Compare
|
Now the build and test jobs work, but is still using the |
|
My current guess is that this is due to installing boost compiled with VS 2017. |
chriseth
force-pushed
the
windows-tests
branch
from
eeeab03 to
7a8c234
Compare
chriseth
force-pushed
the
windows-tests
branch
2 times, most recently
from
8a4f563 to
afe98cc
Compare
| .. _Visual Studio 2017: https://www.visualstudio.com/vs/ | ||
| .. _Visual Studio 2017 Build Tools: https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2017 | ||
| .. _Visual Studio 2019: https://www.visualstudio.com/vs/ | ||
| .. _Visual Studio 2019 Build Tools: https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2019 | ||
|
|
||
| Dependencies Helper Script |
There was a problem hiding this comment.
Maybe we should switch the Or, on windows: part of this to scripts/install_deps.ps1 now? And maybe mention that that doesn't attempt to install dependencies globally, but just puts them in deps/... and that it will not only build boost, but also fetch a cmake version that can be used to deps/cmake...
There was a problem hiding this comment.
If so we can remove scripts/install_deps.bat...
There was a problem hiding this comment.
Can you do that, please? :)
There was a problem hiding this comment.
I just quickly wrote up something at both places, but in a hurry, so better to have another look later I guess.
| @@ -362,7 +362,7 @@ And for Windows: | |||
|
|
|||
| mkdir build | |||
| cd build | |||
| cmake -G "Visual Studio 15 2017 Win64" .. | |||
| cmake -G "Visual Studio 16 2019 Win64" .. | |||
There was a problem hiding this comment.
Maybe we should also mention here that, if this is supposed to use the boost version built by install_deps.ps1, it also needs -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded and -DBoost_DIR="..\deps\boost\lib\cmake\Boost-<BoostVersion>?
There was a problem hiding this comment.
(Which is the complications I warned about in #9811 (comment) ;-))
There was a problem hiding this comment.
Can you do that change, please?
|
Looks like the release build is not a release build. |
chriseth
force-pushed
the
windows-tests
branch
from
eccedc1 to
5935905
Compare
chriseth
force-pushed
the
windows-tests
branch
2 times, most recently
from
56a7b47 to
d6a0382
Compare
chriseth
force-pushed
the
windows-tests
branch
from
d6a0382 to
165f898
Compare
|
Finally working! |
Getting Windows tests running on CI
cmake -DCMAKE_CXX_VERSION=20(defaulting to 17); as this did conflict with AppVeyor CI always passing its own toolchain file (to vcpkg)Notes
This PR is based on #9694 which is based on top of #9693