Make rebuilt macOS binaries executable #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Dec 16, 2020
| @@ -316,6 +316,7 @@ jobs: | |||
| - name: Commit and push the binary | |||
| run: | | |||
| cd solc-bin/ | |||
| chmod 0755 ../solc | |||
There was a problem hiding this comment.
So basically the download-artifact step doesn't apply this (it doesn't convey this information).
There was a problem hiding this comment.
Yeah. Artifacts seem to be stored as zips internally and zips do not preserve the flags so it might be due to that.
Another possibility is that it could be just our build system not making it executable. But I think it's unlikely and I didn't want to investigate that too deeply. Putting chmod here will work in either case.
axic
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my rebuild script (#53) does not mark the binaries as executable before committing them and now I constantly have to do it manually when working with them. It would be best to have that bit set in the repo.