Update node.js dependencies to the latest versions to pull in newer keccak module #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue with
ethereumjs-util
pulling in an old version ofkeccak
version that does not build on node.js >= 12. The problem was not makingnpm install fail
because there's a fallback to the pure JS implementation but it ran slower because of that. After the update the script runs in ~5 minutes in a github action, compared to ~8 minutes before.npm install
output before this PRnpm install
output after this PR