import/export accounts #550

zelig · 2015-03-23T14:35:42Z

https://github.com/ethereum/go-ethereum/wiki/Managing-your-accounts

cli: add passwordfile flag
cli: change unlock flag only takes account
cli: with unlock you are prompted for password or use passfile with password flag
cli: unlockAccount used in normal client start (run) and accountExport
cli: getPassword used in accountCreate and accountImport
accounts: Manager.Import, Manager.Export
crypto: SaveECDSA (to complement LoadECDSA) to save to file
crypto: NewKeyFromECDSA added (used in accountImport and New = generated constructor)

fjl · 2015-03-24T12:00:48Z

cmd/ethereum/main.go

+
+Note:
+Since you can directly copy your encrypted accounts to another ethereum instance, this import/export mechanism is not needed when you transfer an account between nodes.
+					`,


Please wrap these strings at column 80.

obscuren · 2015-03-24T18:08:06Z

fjl · 2015-03-25T06:59:47Z

accounts/account_manager.go

@@ -101,6 +101,17 @@ func (am *Manager) firstAddr() ([]byte, error) {
 	return addrs[0], nil
 }

+func (am *Manager) getKey(addr []byte, keyAuth string) (*crypto.Key, error) {
+	if len(addr) == 0 {


This is not a good idea. Unlock(nil, ...) should never work.
It's like saying: "please unlock some random account with this passphrase".

This change is also unrelated to the account import/export.

An error needs to be returned if an invalid addr is passed.

fjl · 2015-03-25T17:16:03Z

We can merge this once you remove crypto.SaveECDSA.

fjl · 2015-03-25T17:16:25Z

Also maybe squash the changes together if you want.

obscuren · 2015-03-26T12:58:00Z

cmd/ethereum/main.go

+	am := utils.GetAccountManager(ctx)
+	auth := unlockAccount(ctx, am, account)
+
+	err := am.Export(keyfile, common.FromHex(account), auth)


We shouldn't export private keys directly to disk. Export encrypted keys only. Maybe supply an additional tool to actually export the private key.

People tend to forget they exported something to file. Ending up with your HDD compromised will lead to your private keys being compromised. We should try to do everything we can do minimise the risk. Supplying an additional tool means "look, you can do it, we don't recommend it, but feel free to use this tool."

Importing is a different story. Would it be possible to check the format of the key and assume either "encrypted key" or "unencrypted key"?

The current files have different JSON schema for encrypted and unencrypted, but it's not very clean to use compared to a proper header. @fjl and I discussed this before and talked about adding a common format with a header that specifies whether what follows is encrypted or not.

so currently there are 2 consistent options which both make sense:

1 leave everything there as is.

we support unencrypted keys anyway as part of the cli with a simple flag then no point in worrying about unencrypted export for now.

Its all developers anyway. and it is hidden in a subcommand. You really need to be tech savvy to do this.

2 full paranoid mode:

remove export

remove plain text key-store

remove --unencrypted-keys flag

testers can setup a coinbase and unlock it all non-interactively with the following commands:

ethereum -datadir /tmp/eth/42 -logfile /dev/null -password <(echo -n notsosecret) account new ethereum -datadir /tmp/eth/42 -logfile /dev/null -port 30342 js <(echo 'console.log(admin.nodeInfo().NodeUrl)') > enode ethereum -datadir /tmp/eth/42 -logfile 42.log -port 30342- password <(echo -n notsosecret) -unlock coinbase .....<further flags to run the node>

and therefore test team won't even need a custom built client

Option number 2 :-)

- cli: add passwordfile flag - cli: change unlock flag only takes account - cli: with unlock you are prompted for password or use passfile with password flag - cli: unlockAccount used in normal client start (run) and accountExport - cli: getPassword used in accountCreate and accountImport - accounts: Manager.Import, Manager.Export - crypto: SaveECDSA (to complement LoadECDSA) to save to file - crypto: NewKeyFromECDSA added (used in accountImport and New = generated constructor)

- extract accounts.getKey method - if given empty address it retrieves coinbase (first account) - cli -unlock coinbase will unlock coinbase

- accounts: remove Manager.getKey - cli: for -unlock coinbase, use account manager Coinbase()

…ead /path: is a directory") msg

- remove account export functionality from CLI - remove accountExport method, - remove unencrypted-keys flag from everywhere - improve documentation

import/export accounts

Release v1.1.5

…inniting `environment` (ethereum#550) Reduce rawdb calls

Implement EIPs to support the increase of TX size limit configuration. EIPs: 2464, 2364, 2124

zelig added the in progress label Mar 23, 2015

zelig force-pushed the frontier/cli-key branch 4 times, most recently from e18bfef to 2704b7e Compare March 23, 2015 22:53

fjl reviewed Mar 24, 2015
View reviewed changes

zelig force-pushed the frontier/cli-key branch from 2704b7e to 1147eb0 Compare March 24, 2015 16:53

zelig force-pushed the frontier/cli-key branch 2 times, most recently from 7352dfc to 22fd1e2 Compare March 24, 2015 22:58

fjl reviewed Mar 25, 2015
View reviewed changes

zelig force-pushed the frontier/cli-key branch from d4bd44c to dd8344b Compare March 25, 2015 16:13

obscuren reviewed Mar 26, 2015
View reviewed changes

zelig added 10 commits March 26, 2015 19:00

blockpool: wrap intermittent status test in a loop

859f1f0

unlocking coinbase

fd8d18e

- extract accounts.getKey method - if given empty address it retrieves coinbase (first account) - cli -unlock coinbase will unlock coinbase

cli: fix liner not closing (spuriously opened) in noninteractive jsre

1c4c71d

cli: help formatting

34d5a6c

cli: implement ethereum presale wallet import via cli

d1b52ef

cli test: fix test newJSRE interactive argument

fee224f

Applying: fix adming js test regression (maybe otto update?)

23e41a5

common: remove WriteFile and ReadAllFile (use ioutil instead)

4ec38e3

unlocking coinbase without knowing address

11d2ebc

- accounts: remove Manager.getKey - cli: for -unlock coinbase, use account manager Coinbase()

zelig added 2 commits March 26, 2015 19:00

output error message if unlock address is invalid (fixes the wierd "r…

abbdf41

…ead /path: is a directory") msg

max paranoia mode to UNsupport unencrypted keys entirely

7577d12

- remove account export functionality from CLI - remove accountExport method, - remove unencrypted-keys flag from everywhere - improve documentation

zelig force-pushed the frontier/cli-key branch from dd8344b to 7577d12 Compare March 26, 2015 19:04

zelig added a commit to ethersphere/system-testing that referenced this pull request Mar 26, 2015

update go cli params according to ethereum/go-ethereum#550

92babbe

zelig mentioned this pull request Mar 26, 2015

update go cli params according to new spec [DO NOT MERGE YET] ethereum/system-testing#61

Merged

obscuren added a commit that referenced this pull request Mar 26, 2015

Merge pull request #550 from ethersphere/frontier/cli-key

829240c

import/export accounts

obscuren merged commit 829240c into ethereum:develop Mar 26, 2015

obscuren removed the in progress label Mar 26, 2015

zelig mentioned this pull request Mar 26, 2015

settable etherbase #580

Merged

obscuren mentioned this pull request Mar 26, 2015

Additional CLI account commands #541

Closed

4 tasks

nolash pushed a commit to nolash/go-ethereum that referenced this pull request May 25, 2018

swarm/network: Increase timeout in overlay test sim (ethereum#550)

8126c9d

maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Nov 22, 2021

Merge pull request ethereum#550 from binance-chain/develop

8ff7d53

Release v1.1.5

elee1766 pushed a commit to elee1766/go-ethereum that referenced this pull request Dec 23, 2023

perf(miner): reduce rawdb calls for getting StartL1QueueIndex when …

a8a9dc8

…inniting `environment` (ethereum#550) Reduce rawdb calls

s1na pushed a commit to s1na/go-ethereum that referenced this pull request Dec 2, 2024

Merge pull request ethereum#550 from XinFinOrg/increase-txpool-EIP-2464

b09292a

Implement EIPs to support the increase of TX size limit configuration. EIPs: 2464, 2364, 2124

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

import/export accounts #550

import/export accounts #550

zelig commented Mar 23, 2015

fjl Mar 24, 2015

obscuren commented Mar 24, 2015

fjl Mar 25, 2015

obscuren Mar 25, 2015

fjl commented Mar 25, 2015

fjl commented Mar 25, 2015

obscuren Mar 26, 2015

Gustav-Simonsson Mar 26, 2015

zelig Mar 26, 2015

obscuren Mar 26, 2015

import/export accounts #550

import/export accounts #550

Conversation

zelig commented Mar 23, 2015

fjl Mar 24, 2015

Choose a reason for hiding this comment

obscuren commented Mar 24, 2015

fjl Mar 25, 2015

Choose a reason for hiding this comment

obscuren Mar 25, 2015

Choose a reason for hiding this comment

fjl commented Mar 25, 2015

fjl commented Mar 25, 2015

obscuren Mar 26, 2015

Choose a reason for hiding this comment

Gustav-Simonsson Mar 26, 2015

Choose a reason for hiding this comment

zelig Mar 26, 2015

Choose a reason for hiding this comment

obscuren Mar 26, 2015

Choose a reason for hiding this comment