Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm: set basefee to 0 internally on eth_call #28470

Merged
merged 8 commits into from
Nov 8, 2023
Merged

core/vm: set basefee to 0 internally on eth_call #28470

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
849c0d4
core/vm: set basefee to 0 internally on eth_call
karalabe Nov 6, 2023
de24a7a
core: nicer 0-basefee, make it work for blob fees too
karalabe Nov 7, 2023
5f39342
internal/ethapi: make tests a bit more complex
karalabe Nov 7, 2023
9da87f8
core: fix blob fee checker
karalabe Nov 7, 2023
2cd4ccf
core: make code a bit more readable
karalabe Nov 7, 2023
7aff365
core: fix some test error strings
karalabe Nov 7, 2023
4544026
core/vm: Get rid of weird comment
karalabe Nov 7, 2023
ff2d1d7
core: dict wrong typo
karalabe Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/state_transition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ func (st *StateTransition) preCheck() error {
if st.evm.ChainConfig().IsCancun(st.evm.Context.BlockNumber, st.evm.Context.Time) {
if st.blobGasUsed() > 0 {
// Skip the checks if gas fields are zero and blobBaseFee was explicitly disabled (eth_call)
if !st.evm.Config.NoBaseFee && msg.BlobGasFeeCap.BitLen() > 0 {
if !st.evm.Config.NoBaseFee || msg.BlobGasFeeCap.BitLen() > 0 {
Copy link
Contributor

@holiman holiman Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to, again, look at it for a while before my brain parsed it out fully. Yeah it's ok now, but I'd prefer having it rewritten for clarity:

// skip checks if basefee was disabled and blobBaseFee is zero (eth_call) 
skipCheck := st.evm.Config.NoBaseFee && msg.BlobGasFeeCap.BitLen() == 0
if !skipCheck {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed this fix and also added it to the 1559 basefee

if l := msg.BlobGasFeeCap.BitLen(); l > 256 {
return fmt.Errorf("%w: address %v, blobGasFeeCap bit length: %d", ErrFeeCapVeryHigh,
msg.From.Hex(), l)
Expand Down