Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash #28084

Merged
merged 3 commits into from
Oct 17, 2023
Merged

api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash #28084

merged 3 commits into from
Oct 17, 2023

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Sep 9, 2023

Adds BlockHash to CallOpts so contract bindings can be used to call contracts at a specific block hash. Previously only block number or pending was supported.

Backwards compatibility is preserved by introducing a new BlockHashContractCaller interface with the CallContractAtHash and CodeAtHash methods required from the backend, following a similar pattern to PendingContractCaller. Simulated backend is updated to support the new methods and CodeAtHash has been added to ethclient.Client - it already supported CallContractAtHash.

Fixes #28017

MariusVanDerWijden
MariusVanDerWijden approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton
Copy link
Contributor Author

@MariusVanDerWijden Mind hitting merge for me? :)

@holiman holiman requested a review from fjl September 19, 2023 12:57
@karalabe
Copy link
Member

We've discussed this last week. Should be ok, but it creates a strange asymmetric API. Would be nice to add the "AtHash" methods for everything (code, balance, nonce, etc).

@ajsutton
Copy link
Contributor Author

We've discussed this last week. Should be ok, but it creates a strange asymmetric API. Would be nice to add the "AtHash" methods for everything (code, balance, nonce, etc).

@karalabe Added BalanceAtHash, NonceAtHash and StorageAtHash to complete the set.

holiman
holiman approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karalabe
karalabe approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@holiman holiman added this to the 1.13.5 milestone Oct 17, 2023
@karalabe karalabe merged commit b85c860 into ethereum:master Oct 17, 2023
@ajsutton ajsutton deleted the aj/binding-hash branch October 19, 2023 00:12
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@ajsutton @devopsbo3
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
9f7f4a7 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "api/bind: add CallOpts.BlockHash to allow calling contracts a…
1661204 
…t a specific block hash (ethereum#28084)"

This reverts commit 9f7f4a7.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "api/bind: add CallOpts.BlockHash to allow calling contracts a…
91f0865 
…t a specific block hash (ethereum#28084)"

This reverts commit 9f7f4a7.
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2023
Merged
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@ajsutton @Dergarcon
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
fbad73d 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 9, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
733b75b 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 9, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
24ece14 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
1597ea3 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
309877c 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
f1ed8fe 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
32d3228 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
2bcfef2 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 11, 2025
@ajsutton @gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
9d751bc 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
1b3f505 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
8073fbb 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
10fbd80 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
31841cf 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
@chiphamskymavis chiphamskymavis mentioned this pull request Jan 22, 2025
Open
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
64428ce 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 23, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
876c2a7 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
@gzliudan
api/bind: add CallOpts.BlockHash to allow calling contracts at a spec…
df87605 
…ific block hash (ethereum#28084)

* api/bind: Add CallOpts.BlockHash to allow calling contracts at a specific block hash.

* ethclient: Add BalanceAtHash, NonceAtHash and StorageAtHash functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman holiman approved these changes

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@fjl fjl Awaiting requested review from fjl fjl is a code owner

Assignees
No one assigned
Labels
status:triage
Projects
None yet
Milestone
1.13.5
Development

Successfully merging this pull request may close these issues.

Support BlockHash in contract bindings
4 participants
@ajsutton @karalabe @holiman @MariusVanDerWijden