Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus/ethash: increase seal timeout for tests #22162

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

MariusVanDerWijden
Copy link
Member

It seems that the 2 second timeout is not enough for travis

--- FAIL: TestTestMode (2.00s)
    ethash_test.go:53: sealing result timeout
FAIL
coverage: 70.2% of statements
FAIL	github.com/ethereum/go-ethereum/consensus/ethash	11.261s

https://travis-ci.com/github/ethereum/go-ethereum/jobs/457951964
https://travis-ci.com/github/ethereum/go-ethereum/jobs/469377305
https://travis-ci.com/github/ethereum/go-ethereum/jobs/469031088

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fjl fjl changed the title travis: increase ethash seal timeout for tests consensus/ethash: increase seal timeout for tests Jan 13, 2021
@fjl fjl merged commit 2aaff0a into ethereum:master Jan 13, 2021
bulgakovk pushed a commit to bulgakovk/go-ethereum that referenced this pull request Jan 26, 2021
It seems that the 2 second timeout is not enough for Travis CI:

   --- FAIL: TestTestMode (2.00s)
       ethash_test.go:53: sealing result timeout
@MariusVanDerWijden MariusVanDerWijden deleted the ethashseal branch November 30, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants