les: remove useless protocol defines #22115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
remove-aux-les-type
branch
from
b68b111 to
f6a012a
Compare
DGKSK8LIFE
approved these changes
Jan 5, 2021
zsfelfoldi
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
LGTM. Note: I originally added the auxRoot for a complex trustless CHT verification scheme (client asks multiple servers, asks merkle proofs to find out which one is right if the servers return different roots). Now I gave up on this plan because I don't think it's worth the effort so I think it's fine to remove this feature.
DGKSK8LIFE
suggested changes
Jan 6, 2021
bulgakovk
pushed a commit
to bulgakovk/go-ethereum
that referenced
this pull request
Jan 26, 2021
This PR has two changes in the les protocol: - the auxRoot is not supported. See ethereum/devp2p#171 for more information - the empty response will be returned in GetHelperTrieProofsMsg request if the merkle proving is failed. note, for backward compatibility, the empty merkle proof as well as the request auxiliary data will still be returned in les2/3 protocol no matter the proving is successful or not. the proving failure can happen e.g. request the proving for a non-included entry in helper trie (unstable header).
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two changes in the les protocol.
auxRootis not supported. See LES: change the GetHelperTrieProofs message in the les4 devp2p#171 for more informationGetHelperTrieProofsMsgrequest if the merkle proving is failed