Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: set gasLimit in '--dev' mode to be 9000000 #21323

Merged
merged 2 commits into from
Jul 16, 2020
Merged

core: set gasLimit in '--dev' mode to be 9000000 #21323

merged 2 commits into from
Jul 16, 2020

Conversation

madjarevicn
Copy link
Contributor

In order to make testing in --dev mode more used, and support more cases, I changed the gasLimit in --dev mode to 9 milion. Mainnet currenly supports almost 10m, which is much closer to it.

@fjl fjl added this to the 1.9.17 milestone Jul 13, 2020
@karalabe
Copy link
Member

Mainnet currently is at 12M, might as well bump it all the way there.

@karalabe
Copy link
Member

karalabe commented Jul 15, 2020 •
edited
Loading

Btw, I also saw that in dev mode we don't have 1 wei allocations for newer precompiles. Might be worthwhile to fix those too at the same time.

@madjarevicn
Copy link
Contributor Author

madjarevicn commented Jul 15, 2020 via email

@karalabe
Copy link
Member

sgtm

@madjarevicn
Copy link
Contributor Author

Hey Folks.

I have added also 1 wei allocation for newer precompiles, and updated gasLimit to 11.5 milion, since regarding June 21st 2020, blocks are closely 12m, so 0.5m less would assure that everything working on --dev should work on mainnet as well.

karalabe
karalabe approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@karalabe karalabe merged commit 9e88224 into ethereum:master Jul 16, 2020
@dahu33
Copy link
Contributor

dahu33 commented Jul 21, 2020

Not sure if this was intended but this change was a breaking change: if you had an existing chain in '--dev' mode, geth v1.9.17 will refuse to start with:

Fatal: Error starting protocol stack: database contains incompatible genesis (have f60d6c04a6b6264f1c89845b697293e2c242bee3d8463968848b16198a7c2807, new 1bf2ffd2d8981fda0a342215ef5988889fe76cf613a6a744fd663da7e760576b)

@karalabe
Copy link
Member

@dahu33 Hmm, that's odd. Geth should load the genesis from disk. Otherwise the random signer funding wouldn't work across restarts either. Lemme take a closer look.

@karalabe
Copy link
Member

Yup, can repro it, will try to fix it asap.

@karalabe karalabe mentioned this pull request Jul 21, 2020
Merged
@karalabe
Copy link
Member

@dahu33 Could you try if #21352 fixes it for you?

@dahu33
Copy link
Contributor

dahu33 commented Jul 21, 2020

@dahu33 Could you try if #21352 fixes it for you?

Thanks for the quick fix, #21352 fixes it.

@ricardolyn ricardolyn mentioned this pull request Feb 19, 2021
Merged
9 tasks
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
@madjarevicn @enriquefynn
core: raise gas limit in --dev mode, seed blake precompile (ethereum…
33469ce 
…#21323)

* Set gasLimit in --dev mode to be 9m.

* core: Set gasLimit to 11.5 milion and add 1 wei allocation for BLAKE2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.17
Development

Successfully merging this pull request may close these issues.
5 participants
@madjarevicn @karalabe @dahu33 @holiman @fjl