eth: core/rawdb: p2p/enode: multiple data race fixes #20916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the reuse of error channels throughout the tests, the golang race tester complains to test use `go test -count=1 -run=TestForkIDSplit ./... -race`
fixes a data race between genIter.Next() and genIter.Close()
MariusVanDerWijden
requested review from
fjl,
holiman,
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
karalabe
reviewed
Apr 14, 2020
|
|
||
| select { | ||
| case err := <-errc: | ||
| case err := <-errc3: |
There was a problem hiding this comment.
This fix touches code that I've heavily rewritten in the snapshot-sync branch. We might want to either open the PR against my branch or wait until that's in.
karalabe
reviewed
Apr 14, 2020
| return nil, errOutOfBounds | ||
| } | ||
| t.lock.RLock() | ||
| startOffset, endOffset, filenum, err := t.getBounds(item - uint64(offset)) | ||
| startOffset, endOffset, filenum, err := t.getBounds(item - uint64(t.itemOffset)) |
There was a problem hiding this comment.
Please open a PR with this (rawdb) fix only, that can be merged
|
closed in favour of #20919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found multiple pending data races, they are mostly in tests so very low impact.
eth:Due to the reuse of error channels throughout the tests, the golang race tester complains
to test use
go test -count=1 -run=TestForkIDSplit ./... -racecore/rawdb:closes #20420
p2p/enode:fixes a data race between genIter.Next() and genIter.Close()