-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Eth1-specs Repo & Add Network Upgrades Info #24
Conversation
Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
cc: @holgerd77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested minor edits. Wondering if the upgrade process flow can be added for a quick visual of the phases and EIP status instructions.
Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
@poojaranjan thanks for the quick review! Addressed the bulk of your comments in the last commit. Still two open threads to discuss. Re: the diagram, if we have an updated one, yes, we should add it We can also add it in a subsequent PR if we don't have one now. |
@timbeiko Diagram: I have got the updated diagram here. One major change from the earlier version, CFI approved is moved to CFI phase. Looks like it was mistakenly shown in the Devnet phase. If you'd rather like to have only one CFI instead of applied and approved, I can make the edits, let me know. |
Thanks @poojaranjan just added the diagram in a separate commit 😄 ! |
Two big changes in this PR (I know...):
Given that ethereum/pm#295 and #23 are still opened, I did not clarify where CFI is being tracked, or whether it resets every upgrade. Based on the outcome of these two issues, more changes will be necessary, but I think merging this is a net improvement.