Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consume/hive): add HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION #1093

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(consume/hive): add HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION #1093

merged 1 commit into from
Jan 21, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 20, 2025 •
edited by winsvega
Loading

Adds HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION to the ruleset.

🗒️ Description

Based on this hive PR: ethereum/hive#1215

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz
feat(plugins/hive): Update ruleset.py
e1e5b02 
Adds `HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION` to the ruleset.
@marioevz marioevz requested a review from danceratopz January 20, 2025 14:10
@marioevz marioevz mentioned this pull request Jan 20, 2025
Closed
16 tasks
winsvega
winsvega approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hive pr is merged

@danceratopz danceratopz changed the title feat(plugins/hive): Update ruleset.py feat(consume/hive): add fee update fraction to hive ruleset Jan 21, 2025
danceratopz
danceratopz approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danceratopz danceratopz changed the title feat(consume/hive): add fee update fraction to hive ruleset feat(consume/hive): add HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION Jan 21, 2025
@danceratopz danceratopz merged commit 7e5ecfa into main Jan 21, 2025
21 checks passed
@danceratopz danceratopz deleted the marioevz-patch-1 branch January 21, 2025 09:12
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
@marioevz @fselmo
feat(consume/hive): add HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION (e…
f3a032c 
…thereum#1093)
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@marioevz @codeofcarson
feat(consume/hive): add HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION (e…
ec8e6b4 
…thereum#1093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

@danceratopz danceratopz danceratopz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marioevz @winsvega @danceratopz