Align PeerDAS sampling_size
comparison units
#4060
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current sampling size logic mixes different units -
SAMPLES_PER_SLOT
is measured in column samples, whilecustody_group_count
refers to custody groups:This discrepancy causes issues when
NUMBER_OF_COLUMNS
does not exactly matchNUMBER_OF_CUSTODY_GROUPS
, potentially leading to incorrectsampling_size
.This PR converts the
custody_group_count
to column count.