Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

ChainID support in testeth #5727

Merged
merged 1 commit into from
Aug 28, 2019
Merged

ChainID support in testeth #5727

merged 1 commit into from
Aug 28, 2019

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 27, 2019

With this fix testeth passes ChainID tests from ethereum/tests#627

The simple fix is to always use the same ChainID from the mainnet config, assuming all network configs use only this ChainID.

Note: VM tests still always return 0 ChainID, I didn't bother to fix it as VM tests are not maintained anyway.

return {blockHeader, _lastBlockHashes, 0, 0};

dev::test::FakeExtVM test(eth::EnvInfo{BlockHeader{}, lastBlockHashes, 0, 0});

@gumb0 gumb0 added this to the Istanbul milestone Aug 27, 2019
@gumb0 gumb0 requested review from winsvega and chfast August 27, 2019 10:36
@codecov-io
Copy link

Codecov Report

Merging #5727 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5727      +/-   ##
==========================================
+ Coverage    63.2%   63.23%   +0.02%     
==========================================
  Files         353      353              
  Lines       30271    30274       +3     
  Branches     3390     3390              
==========================================
+ Hits        19134    19144      +10     
+ Misses       9904     9894      -10     
- Partials     1233     1236       +3

@gumb0 gumb0 merged commit 6c3628e into master Aug 28, 2019
@gumb0 gumb0 deleted the chainid-testeth branch August 28, 2019 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants