Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7002: Add high fees check to Fee overpayment code #9427

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Update EIP-7002: Add high fees check to Fee overpayment code #9427

merged 2 commits into from
Mar 4, 2025

Conversation

mkalinin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added c-update Modifies an existing proposal t-core labels Feb 28, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 28, 2025 •
edited
Loading

✅ All reviewers have approved.

lightclient
lightclient reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making FEE_THRESHOLD a parameter to addWithdrawal so it is a bit more clear that it is configurable?

@lightclient
Copy link
Member

Generally LGTM though

@mkalinin mkalinin marked this pull request as ready for review March 3, 2025 11:16
@mkalinin mkalinin requested a review from eth-bot as a code owner March 3, 2025 11:16
@mkalinin mkalinin closed this Mar 4, 2025
@mkalinin mkalinin reopened this Mar 4, 2025
@eth-bot eth-bot enabled auto-merge (squash) March 4, 2025 05:07
eth-bot
eth-bot approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit f73240f into ethereum:master Mar 4, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient left review comments

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkalinin @eth-bot @lightclient