-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update test cases #9425
base: master
Are you sure you want to change the base?
update test cases #9425
Conversation
File
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the JSONs have now changed to a one-liner, I'd suggest keeping the original format with line breaks. This also makes it more visible to see which tests are added. Now it should be manually checked that all original tests are still in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the mul
precompile for both G1 and G2 is removed, these inputs can be fed into the multiexp precompile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks good comment, I will add them back
I added these tests to our local tests and we sadly fail two, so it seems like we also have the bug (in this PR: ethereumjs/ethereumjs-monorepo#3896) The linked file are formatted JSONs with newlines in them, our dev tools do this when it is saved. Feel free to use :) |
This PR updated the EIP-2537 test cases to cover more corner cases for paring and MSM
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: