Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test cases #9425

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

update test cases #9425

wants to merge 18 commits into from

Conversation

asanso
Copy link
Contributor

@asanso asanso commented Feb 28, 2025

This PR updated the EIP-2537 test cases to cover more corner cases for paring and MSM

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@asanso asanso requested a review from eth-bot as a code owner February 28, 2025 09:31
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 28, 2025

File EIPS/eip-2537.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the JSONs have now changed to a one-liner, I'd suggest keeping the original format with line breaks. This also makes it more visible to see which tests are added. Now it should be manually checked that all original tests are still in here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the mul precompile for both G1 and G2 is removed, these inputs can be fed into the multiexp precompile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good comment, I will add them back

@jochem-brouwer
Copy link
Member

multiline-json.zip

I added these tests to our local tests and we sadly fail two, so it seems like we also have the bug (in this PR: ethereumjs/ethereumjs-monorepo#3896)

The linked file are formatted JSONs with newlines in them, our dev tools do this when it is saved. Feel free to use :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants