Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7620: Move to Review #9417

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update EIP-7620: Move to Review #9417

wants to merge 4 commits into from
+23 −6

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Feb 27, 2025

Makes note in all the EIPs concerning EOF contract creation, that whenever not explicitly stated, legacy rules should be had in mind.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft s-review This EIP is in Review s-stagnant This EIP is Stagnant t-core labels Feb 27, 2025
@pdobacz pdobacz force-pushed the eof-tx-create-vs-legacy branch from ed7f486 to adb106f Compare February 27, 2025 12:06
@github-actions github-actions bot added c-status Changes a proposal's status and removed s-stagnant This EIP is Stagnant labels Feb 27, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 27, 2025 •
edited
Loading

File EIPS/eip-7698.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-review Waiting on editor to review label Feb 27, 2025
@eth-bot eth-bot changed the title Update EIP-7620/7698/7873 - Defer EOF creation rules to legacy Update EIP-7620: Move to Review Feb 27, 2025
@pdobacz pdobacz changed the title Update EIP-7620: Move to Review Update EIP-7620: Move to Review & EOF creation rules vs legacy Feb 27, 2025
shemnon
shemnon reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop the in 7873. I'd do an inline comment but github won't let me.

@eth-bot eth-bot changed the title Update EIP-7620: Move to Review & EOF creation rules vs legacy Update EIP-7620: Move to Review Feb 28, 2025
@pdobacz pdobacz requested a review from shemnon February 28, 2025 17:29
@pdobacz pdobacz marked this pull request as ready for review February 28, 2025 18:08
@pdobacz pdobacz requested a review from eth-bot as a code owner February 28, 2025 18:08
@pdobacz pdobacz closed this Mar 1, 2025
@pdobacz pdobacz reopened this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
c-status Changes a proposal's status c-update Modifies an existing proposal e-review Waiting on editor to review s-draft This EIP is a Draft s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdobacz @eth-bot @shemnon