Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1015: Fix Typographical Errors #9140

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

Dimitrolito
Copy link
Contributor

This pull request corrects several typographical errors across multiple EIP documents. The changes include the addition of hyphens in compound adjectives and the correction of article usage (i.e., "a" vs. "an").

Changes:

  1. Added hyphen in "three-step" in EIP-101.
  2. Corrected "six month" to "six-month" in EIP-1015.
  3. Changed "a object" to "an object" in EIP-1186.
  4. Added hyphen in "30-second" in EIP-1234.
  5. Corrected "15 second" to "15-second" in EIP-1240.
  6. Corrected "an unique" to "a unique" in EIP-1470.
  7. Changed "a implementation" to "an implementation" in EIP-1485.
  8. Corrected "a address" to "an address" in EIP-158.

@Dimitrolito Dimitrolito requested a review from eth-bot as a code owner December 15, 2024 19:58
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final s-stagnant This EIP is Stagnant s-withdrawn This EIP is Withdrawn t-core t-informational t-interface labels Dec 15, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 15, 2024

File EIPS/eip-1470.md

Requires 1 more reviewers from @thec00n
Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

File EIPS/eip-1015.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn

File EIPS/eip-1186.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Dec 15, 2024
@eth-bot eth-bot changed the title Fix Typographical Errors Update EIP-101: Fix Typographical Errors Dec 15, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 15, 2024
@poojaranjan
Copy link
Contributor

The proposed change to EIP-1234 is trivial and except for EIP-1234, all proposals are Stagnant.
As Stagnant proposals don't accept typo-related PRs, this PR can be closed.

@github-actions github-actions bot removed the s-withdrawn This EIP is Withdrawn label Dec 18, 2024
@eth-bot eth-bot changed the title Update EIP-101: Fix Typographical Errors Update EIP-1015: Fix Typographical Errors Dec 18, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Dec 18, 2024
@github-actions github-actions bot removed the s-final This EIP is Final label Dec 18, 2024
@SamWilsn SamWilsn merged commit cf910e1 into ethereum:master Dec 18, 2024
8 of 9 checks passed
@eth-bot eth-bot added the a-review Waiting on author to review label Dec 18, 2024
Copy link

The commit d42f703 (as a parent of 0bb366e) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-stagnant This EIP is Stagnant t-core t-informational t-interface w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants