-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-6808: Move to Last Call #7685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the Specification section and replaced the png with and svg file * Fixed the assets issue with package-lock * Fixed the licence in the KBT contract * Description + Abstract + Motivation Description bullet points and bolding options * description bolding fix * DApp = dApp funds = FKBT security considerations * Footnotes Updated * Rationale Removal * rationale change * footnote rationale * Funcationality Correction * Backwards Compatibility Section * Footnotes Updated * Applying markdown preferred style --------- Co-authored-by: KBT Admin <kbtstandard@proton.me> Co-authored-by: NickZCZ <122122327+NickZCZ@users.noreply.github.com> Co-authored-by: MihaiORO <122121375+MihaiORO@users.noreply.github.com>
* Rephrased the Reference Implementation. * Changed the heading in Specifications section * Linked the functions to the headings instead of the footnotes + removed unused footnotes * Security Considerations redirect - rationale section * Spelling Check #1 + BIP / SLIP removal + the ERC check + Footnote removal & # Update * motivation topic bolding change * Motivation FTC sentence * FKBT footnotes and corrections update * Key Wallet Reduction --------- Co-authored-by: KBT Admin <kbtstandard@proton.me> Co-authored-by: NickZCZ <NickKBT@proton.me> Co-authored-by: MihaiORO <122121375+MihaiORO@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
* Change an FKBT to a FKBT * Status Change * Added apostrophe to FKBTs * Motivation of small change * KBTs to KBT's --------- Co-authored-by: NickZCZ <NickKBT@proton.me>
* Change an FKBT to a FKBT * Status Change * Added apostrophe to FKBTs * Motivation small change * KBTs to KBT's * ' changes --------- Co-authored-by: NickZCZ <NickKBT@proton.me>
…Token_20 # Conflicts: # EIPS/eip-6808.md
✅ All reviewers have approved. |
Pandapip1
approved these changes
Sep 12, 2023
eth-bot
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no ongoing discussions on the EIP, thus we propose that it be moved to Last Call.