Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6808: Move to Last Call #7685

Merged
merged 31 commits into from
Sep 12, 2023
Merged

Conversation

NarcisCRO
Copy link
Contributor

There are no ongoing discussions on the EIP, thus we propose that it be moved to Last Call.

KBTStandardAdmin and others added 30 commits March 31, 2023 13:38
* Updated the Specification section and replaced the png with and svg file

* Fixed the assets issue with package-lock

* Fixed the licence in the KBT contract

* Description + Abstract + Motivation

Description bullet points and bolding options

* description bolding fix

* DApp = dApp funds = FKBT security considerations

* Footnotes Updated

* Rationale Removal

* rationale change

* footnote rationale

* Funcationality Correction

* Backwards Compatibility Section

* Footnotes Updated

* Applying markdown preferred style

---------

Co-authored-by: KBT Admin <kbtstandard@proton.me>
Co-authored-by: NickZCZ <122122327+NickZCZ@users.noreply.github.com>
Co-authored-by: MihaiORO <122121375+MihaiORO@users.noreply.github.com>
* Rephrased the Reference Implementation.

* Changed the heading in Specifications section

* Linked the functions to the headings instead of the footnotes + removed unused footnotes

* Security Considerations redirect - rationale section

* Spelling Check #1 + BIP / SLIP removal + the ERC check + Footnote removal & # Update

* motivation topic bolding change

* Motivation FTC sentence

* FKBT footnotes and corrections update

* Key Wallet Reduction

---------

Co-authored-by: KBT Admin <kbtstandard@proton.me>
Co-authored-by: NickZCZ <NickKBT@proton.me>
Co-authored-by: MihaiORO <122121375+MihaiORO@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
* Change an FKBT to a FKBT

* Status Change

* Added apostrophe to FKBTs

* Motivation of small change

* KBTs to KBT's

---------

Co-authored-by: NickZCZ <NickKBT@proton.me>
* Change an FKBT to a FKBT

* Status Change

* Added apostrophe to FKBTs

* Motivation small change

* KBTs to KBT's

* ' changes

---------

Co-authored-by: NickZCZ <NickKBT@proton.me>
@NarcisCRO NarcisCRO requested a review from eth-bot as a code owner September 12, 2023 13:44
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Sep 12, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 12, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Sep 12, 2023
@eth-bot eth-bot enabled auto-merge (squash) September 12, 2023 15:02
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 101bfd0 into ethereum:master Sep 12, 2023
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 6808 state from Review to Last Call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants