Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-5679: Token Minting and Burning #5679

Merged
merged 10 commits into from
Sep 20, 2022
Merged

Add EIP-5679: Token Minting and Burning #5679

merged 10 commits into from
Sep 20, 2022

Conversation

xinbenlv
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@xinbenlv xinbenlv requested a review from eth-bot as a code owner September 18, 2022 04:50
@xinbenlv xinbenlv changed the title EIP-XXX: MINT EIP-5679: MINT Sep 18, 2022
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft labels Sep 18, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 18, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 5679 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@xinbenlv xinbenlv changed the title EIP-5679: MINT EIP-5679: Mint and Burn Sep 18, 2022
@github-actions github-actions bot added t-erc and removed e-number Waiting on EIP Number assignment labels Sep 18, 2022
@xinbenlv xinbenlv changed the title EIP-5679: Mint and Burn EIP-5679: Token Minting and Burning Sep 18, 2022
@Pandapip1 Pandapip1 changed the title EIP-5679: Token Minting and Burning Add EIP-5679: Token Minting and Burning Sep 18, 2022
Pandapip1
Pandapip1 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eth-bot eth-bot enabled auto-merge (squash) September 20, 2022 00:07
@eth-bot eth-bot merged commit 3ed6a60 into ethereum:master Sep 20, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@xinbenlv @nachomazzara
Add EIP-5679: Token Minting and Burning (ethereum#5679)
c4330c3 
* init

* Update ERC number

* Add content

* Add discussion-to

* Add ERC-165 identifiers

* Change public to external

* Update with batch and safe methods and add rationale.

* Fix format

* Fix EIPW errors

* Add mentioning of EIP-777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinbenlv @eth-bot @Pandapip1