Create BASEFEE opcode EIP #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahZoltu
approved these changes
Jan 14, 2021
| |:----: |:-----: |:------: |:----: | | ||
| | 0x48 | 0 | 1 | 2 | | ||
|
|
||
| Attempted execution of a `BASEFEE` prior to `eip-1559` fork causes an _`abort`_: terminate execution with an `Invalid Operation` exception. |
There was a problem hiding this comment.
This is a given for all new opcodes so isn't required in the EIP. If you want to retain it, consider moving it to the backward compatibility section.
There was a problem hiding this comment.
Ok. I will remote it
Comment on lines
+55
to
+66
| ### Failure 1: No base fee in current block | ||
| Assuming a block header with no base fee (prior to `eip-1559` fork block). | ||
| This should fail, since no base fee is present in current block header. | ||
|
|
||
| Bytecode: `0x4800` (`BASEFEE, STOP`) | ||
|
|
||
| | Pc | Op | Cost | Stack | RStack | | ||
| |-------|-------------|------|-----------|-----------| | ||
| | 0 | BASEFEE | 2 | [] | [] | | ||
| | 1 | STOP | 0 | [] | [] | | ||
|
|
||
| Expected behaviour: Terminate execution with an `Invalid Operation` exception. |
There was a problem hiding this comment.
As mentioned above, I don't think it is necessary to describe behavior prior to the fork block. This would be akin to specifying behavior of an HTTP request prior to the internet being built. 😄
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Add a `BASEFEE (0x48)` that returns the value of the base fee of the current block it is executing in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
BASEFEEopcode EIP.