-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errata: EIP-2200 change variable name SLOAD_GAS to SSTORE_DIRTY_GAS #2526
Conversation
44feb98 #2514 (comment) Wei has withdrawn his proposal, but clarifying these variable names, and that EIP2200 and EIP1884 are not coupled is still important for ETC, though the misspecification does not affect ETH. The "fix" has already been merged into Parity-Ethereum, Geth and Multi-Geth: ethereum/go-ethereum#20646 openethereum/parity-ethereum#11474 I am unsure whether Final EIPs can be corrected in this way within the EIP process. I do not see why not, if the changes are clarifying the specification and not resulting in any changes of consensus for ETH.
Please also add ETC has to make other assumptions around these gas pricing by removing |
@GregTheGreek 1884? |
Yes sorry |
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
I don't have any comment. I don't really see the point of this change, but neither am I opposed to it. |
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
44feb98
#2514 (comment)
Wei has withdrawn his proposal, but clarifying these variable names, and that EIP2200 and EIP1884 are not coupled is still important for ETC, though the misspecification does not affect ETH. The "fix" has already been merged into Parity-Ethereum, Geth and Multi-Geth:
ethereum/go-ethereum#20646
openethereum/parity-ethereum#11474
I am unsure whether Final EIPs can be corrected in this way within the EIP process.
I do not see why not, if the changes are clarifying the specification and not resulting in any changes of consensus for ETH.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: