Mention ERC-831 ENS condition to prevent bad implementations #2320
Conversation
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
| @@ -54,7 +54,7 @@ For the syntax of ENS_NAME, please consult ERC #137 defining Ethereum Name Servi | |||
|
|
|||
| ### Semantics | |||
|
|
|||
| `target_address` is mandatory and denotes either the beneficiary of native token payment (see below) or the contract address with which the user is asked to interact. | |||
| `target_address` is mandatory and denotes either the beneficiary of native token payment (see below) or the contract address with which the user is asked to interact. Make sure to respect ERC #831 and add the "pay-" prefix in case you use ENS here. | |||
There was a problem hiding this comment.
@ligi can you please change "ERC #831" to "ERC-831" and make it a link to https://eips.ethereum.org/EIPS/eip-831
There was a problem hiding this comment.
Oh I see you have followed the style of the draft, however this is the recommendation as per EIP-1.
|
@nagydani can you please review? |
|
Ping @nagydani |
|
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
as requested by @3esmit
context:
https://gitter.im/ethereum/EIPs?at=5daf62587477946badafe941
status-im/status-mobile#9238