Backport #8572: fix swapped fee/tip parameters to estimateGas

[ajsutton]

Description

Backports #8572 to the canyon mainnet release branch.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[semgrep-app]

Semgrep found 10 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/universal/Semver.sol: L29
• packages/contracts-bedrock/scripts/upgrades/Multichain.s.sol: L488, L341
• packages/contracts-bedrock/scripts/Deployer.sol: L416, L406, L396, L386, L376, L357, L282

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

• packages/contracts-bedrock/src/L1/SystemConfig.sol: L252

Prefer @notice over @dev in natspec comments

_{Ignore this finding from sol-style-notice-over-dev-natspec.}

Semgrep found 1 sol-style-malformed-revert finding:

• packages/contracts-bedrock/scripts/upgrades/Multichain.s.sol: L144

Malformed revert statement style.

_{Ignore this finding from sol-style-malformed-revert.}

Semgrep found 1 sol-style-input-arg-fmt finding:

• packages/contracts-bedrock/scripts/Deployer.sol: L357

Inputs to functions must be prepended with an underscore (_)

_{Ignore this finding from sol-style-input-arg-fmt.}

Semgrep found 1 nil-check-after-call finding:

• op-node/p2p/node.go: L74-167

Potential p2pmetrics nil dereference when NewBandwidthCounter is called

_{Ignore this finding from nil-check-after-call.}

Semgrep found 1 todos_require_linear finding:

• op-node/rollup/derive/calldata_source.go: L53

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

[trianglesphere]

Fix LGTM

[codecov]

Codecov Report

Merging #8591 (f6c730f) into release/canyon_mainnet (6a9f126) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

@@                    Coverage Diff                     @@
##           release/canyon_mainnet    #8591      +/-   ##
==========================================================
+ Coverage                   45.88%   45.92%   +0.04%     
==========================================================
  Files                         176      176              
  Lines                        7272     7272              
  Branches                     1156     1156              
==========================================================
+ Hits                         3337     3340       +3     
+ Misses                       3809     3804       -5     
- Partials                      126      128       +2     

Flag	Coverage Δ
cannon-go-tests	63.47% <ø> (ø)
chain-mon-tests	26.95% <ø> (ø)
common-ts-tests	26.74% <ø> (ø)
contracts-bedrock-tests	40.24% <ø> (+0.09%)	⬆️
contracts-ts-tests	100.00% <ø> (ø)
core-utils-tests	44.03% <ø> (ø)
sdk-next-tests	41.92% <ø> (ø)
sdk-tests	41.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes