-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.5] Add e2e test to verify etcd is able to automatically fix the issue #19629
Conversation
f1aa95b
to
a274288
Compare
a274288
to
aa09df7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c4d8012
to
15134ba
Compare
ping @serathius @siyuanfoundation We don't need further code change. ETCD server always publishes member's attributes during starting. This update is updated through RAFT. In v3.5 release, member information is from v2 store, which is always valid and correctness. For the etcd/server/etcdserver/api/membership/cluster.go Lines 491 to 503 in 3c65dfa
Since we already allows ETCD to override existing member information, this publish call will help us do migration. So we don't need code change. Just add e2e test to ensure that. |
1ea1162
to
fcd80db
Compare
caused by etcd-io#19557 Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
fcd80db
to
0a51fc2
Compare
/lgtm |
@ivanvc we are ready to release 3.5.20 |
caused by #19557
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.