-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use testify instead of testing in tests/integration #19332
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19332 +/- ##
==========================================
+ Coverage 68.88% 68.93% +0.05%
==========================================
Files 420 420
Lines 35706 35707 +1
==========================================
+ Hits 24596 24615 +19
+ Misses 9687 9674 -13
+ Partials 1423 1418 -5 Continue to review full report in Codecov by Sentry.
|
Please resolve the workflow failure. cc @ivanvc |
a2eaac9
to
76e3813
Compare
Is this PR the last one to fully resolve #18972? |
e9569be
to
9153d06
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
9153d06
to
d1adc37
Compare
/test pull-etcd-robustness-amd64 |
I'm afraid not... There are still many t.Fatal or t.Error that can converted . You can grep this |
I will cut release-3.6 at the end of this week. Afterwards, feel free to continue to change on the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ahrtr , what do you mean by |
We will cut release-3.6 branch in the following 2 days. After that, all following such PRs only go to the |
Description
This uses testify instead of testing for t.Fatal calls in tests/integration package.
@ahrtr, I’m sorry that this is so big but it’s only t.Fatal on errors replacements.
Related to #18972