Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use testify instead of testing in tests/integration #19332

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 4, 2025

Description

This uses testify instead of testing for t.Fatal calls in tests/integration package.

@ahrtr, I’m sorry that this is so big but it’s only t.Fatal on errors replacements.

Related to #18972

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (e13196b) to head (d1adc37).
Report is 10 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19332      +/-   ##
==========================================
+ Coverage   68.88%   68.93%   +0.05%     
==========================================
  Files         420      420              
  Lines       35706    35707       +1     
==========================================
+ Hits        24596    24615      +19     
+ Misses       9687     9674      -13     
+ Partials     1423     1418       -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13196b...d1adc37. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Feb 4, 2025

Please resolve the workflow failure.

cc @ivanvc

@ahrtr
Copy link
Member

ahrtr commented Feb 4, 2025

Is this PR the last one to fully resolve #18972?

@mmorel-35 mmorel-35 force-pushed the testifier/tests branch 4 times, most recently from e9569be to 9153d06 Compare February 4, 2025 19:22
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 changed the title chore: use testify instead of testing in tests chore: use testify instead of testing in tests/integration Feb 4, 2025
@mmorel-35
Copy link
Contributor Author

/test pull-etcd-robustness-amd64

@mmorel-35
Copy link
Contributor Author

Is this PR the last one to fully resolve #18972?

I'm afraid not... There are still many t.Fatal or t.Error that can converted . You can grep this

@ahrtr
Copy link
Member

ahrtr commented Feb 4, 2025

I'm afraid not... There are still many t.Fatal or t.Error that can converted . You can grep this

I will cut release-3.6 at the end of this week. Afterwards, feel free to continue to change on the main only.

@ahrtr ahrtr requested review from fuweid and ivanvc February 4, 2025 21:16
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 85931e1 into etcd-io:main Feb 5, 2025
36 checks passed
@mmorel-35 mmorel-35 deleted the testifier/tests branch February 5, 2025 09:51
@mmorel-35
Copy link
Contributor Author

I will cut release-3.6 at the end of this week. Afterwards, feel free to continue to change on the main only.

@ahrtr , what do you mean by main only ? That seems really touchy . It feels safer to be on a branch but I understand it's a lot to review

@ahrtr
Copy link
Member

ahrtr commented Feb 6, 2025

what do you mean by main only ?

We will cut release-3.6 branch in the following 2 days. After that, all following such PRs only go to the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants