Add alarms metrics for server #14276
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
from
bd87df4 to
62508cf
Compare
Codecov Report
@@ Coverage Diff @@
## main #14276 +/- ##
==========================================
- Coverage 75.51% 75.19% -0.33%
==========================================
Files 456 457 +1
Lines 36919 36923 +4
==========================================
- Hits 27881 27764 -117
- Misses 7316 7415 +99
- Partials 1722 1744 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
ahrtr
reviewed
Jul 26, 2022
ahrtr
reviewed
Jul 27, 2022
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
from
692151c to
71944f7
Compare
ahrtr
reviewed
Jul 28, 2022
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
from
71944f7 to
fcecc08
Compare
ahrtr
reviewed
Jul 28, 2022
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
from
fcecc08 to
3d6aadb
Compare
My pleasure |
|
Please also add a changelog item. |
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
2 times, most recently
from
83caa5d to
7aadeba
Compare
stek29
reviewed
Jul 31, 2022
stek29
reviewed
Jul 31, 2022
|
also, just a nitpick: shouldn't commit message begin with |
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
2 times, most recently
from
8fb3fd0 to
a407be7
Compare
spzala
requested changes
Aug 1, 2022
There was a problem hiding this comment.
lgtm but please see couple of minor in-line comments and answer to the question on namespace. Thanks @yuzhiquan
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
from
a407be7 to
07f3852
Compare
ahrtr
reviewed
Aug 2, 2022
Signed-off-by: yuzhiquanlong <yuzhiquanlong@gmail.com>
yuzhiquan
force-pushed
the
add-alarm-metrics
branch
from
07f3852 to
4c13767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
etcdserver: add alarms metrics for etcd server.
Fix #14234