Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutl: add command to generate shell completion #13142

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Jun 24, 2021

Follow up of #13133.

I've removed the required annotation on the --data-dir flag for snapshot restore, because the completion behaves a lttle unexpected (see here) and because it is defaulted anyways.

Also changed the etcdutl defrag timeout message to link to etcdctl defrag.

@ptabor
Copy link
Contributor

ptabor commented Jun 24, 2021

Thank you.

Could you, please, initiate the change-log:
https://github.com/etcd-io/etcd/edit/main/CHANGELOG-3.5.md -> CHANGELOG-3.6.md
with these changes ?

Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lgtm 👍

PR for changelog is #13143.

@avorima
Copy link
Contributor Author

avorima commented Jun 24, 2021

Could these completion commands also be back-ported to a 3.5 release?

@lilic
Copy link
Contributor

lilic commented Jun 24, 2021

Usually, bugs are the only thing that is backported from what I can tell, but with that said I do not see an issue with users using the main branch etcdctl or etcdutl binaries with the 3.5 release.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @avorima

@spzala spzala merged commit 0d0b6f0 into etcd-io:main Jun 30, 2021
@avorima avorima deleted the etcdutl-completion branch July 15, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants