source-zendesk-support-native: handle cursor paginated responses with no results #2441
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no results When there are no results at all in a cursor paginated response, the after and before cursor fields are not present. Although that shouldn't affect the code flow (the `has_more` field would stop any attempted pagination) a default value is needed to avoid validation errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When there are no results at all in a cursor paginated response, the after and before cursor fields are not present. Although that shouldn't affect the code flow (the
has_morefield would stop any attempted pagination), a default value is needed to avoid validation errors when validating the response.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed
posts(the stream I observed this issue on) does not fail when the response contains noafter_cursororbefore_cursorfield.This change is