Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modern compilers, Python, Jupyter and NumPy releases #5034

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Support modern compilers, Python, Jupyter and NumPy releases #5034

merged 7 commits into from
Feb 11, 2025

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jan 31, 2025 •
edited
Loading

Description of changes:

  • bump all compiler version requirements
    • C++20 core features are now almost fully supported
  • remove now obsolete re-implementations of C++20 algorithms
  • massively reduce the complexity of the CMake build system for tutorials
  • fix deprecation warnings from recent versions of NumPy, SciPy, JupyterLab, and the Python standard library
  • improve code coverage and remove unreachable code

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jngrad added 4 commits February 4, 2025 21:02
@jngrad
Fix python/pip/numpy/cmake portability issues
499c549
@jngrad
Redesign tutorials CI/CD framework
9a834b4 
Use standard CMake targets to configure tutorials. Mark figure files
as dependencies of the Jupyter notebooks that actually use them.
Make python and html targets depend on the original tutorial file in
the source directory. Convert solution cells to hidden solutions.
@jngrad
Bump compiler requirements
97c0b64
@jngrad
Refactor C++ code
175b202 
Replace Utils functionality by equivalent C++20 features.
Remove unused or duplicated code. Improve code coverage.
@jngrad jngrad marked this pull request as ready for review February 6, 2025 23:49
@jngrad jngrad requested a review from reinaual February 6, 2025 23:53
reinaual
reinaual reviewed Feb 7, 2025
View reviewed changes
@jngrad
Refactor script interface
6513363 
Fix dangling references and MPI deadlocks.
Simplify management of object lists and maps.
@jngrad jngrad added the automerge Merge with kodiak label Feb 11, 2025
@kodiakhq kodiakhq bot merged commit cb3b2c9 into espressomd:python Feb 11, 2025
10 checks passed
@jngrad jngrad deleted the requirements branch February 11, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak CMake CodeQuality Core DevOps Improvement ScriptInterface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @reinaual