Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - restyle script summary and annotations in PRs #9184

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jul 31, 2024

similar to .ino builder, prepare a short 'diff' summary of all the requried changes https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary

provide inline annotations, so it is apparent clang-format job is the cause of the PR actions check failure
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message


in theory, cpp-linter-action might work, see
https://github.com/cpp-linter/cpp-linter
https://github.com/cpp-linter/cpp-linter-action

fairly annoying part there would be configuring possible paths...

similar to .ino builder, prepare a short 'diff' summary of all the requried changes
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary

provide inline annotations, so it is apparent clang-format job is the
cause of the PR actions check failure
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message
@mcspr mcspr force-pushed the clang-format/pr-info branch from c8b260a to a6d0d7b Compare July 31, 2024 21:35
@mcspr mcspr merged commit bb3360d into esp8266:master Jul 31, 2024
28 checks passed
@mcspr mcspr deleted the clang-format/pr-info branch July 31, 2024 23:47
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
similar to .ino builder, prepare a short 'diff' summary of all the required changes
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary

provide inline annotations, so it is apparent clang-format job is the
cause of the PR actions check failure
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant