call umm_init just before starting SDK #8207
Merged
+65
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep Basic ASM version of app_entry_redefinable and removed alternate "C"/Extended ASM version. Update comments.
d-a-v
approved these changes
Jul 17, 2021
|
@d-a-v - Yes this is a bug fix ready for merge. I also added a few missing comments, removed an unused build path, and updated the example code to make the zeros more evident should they return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem I saw on a post to esp8266/arduino 👉 : June 30, 2021 11:40 AM, where the BearSSL stack trace is all zero's after an HWDT. I was too slow to recognize I had a problem around the time of his post.
The problem was
umm_initwas being done too early and the Heap was zeroed out before the stack dump was performed.Added code to HWDT example to use StackThunk. This should make the problem more visible in the future should it return.