Pickup some loose ends from PR #7122 #7218
Merged
+38
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckCycles (like in rest of core API for this type of use). Fix/clarify comments. Fix redundancies in Tone, end Tone waveform on exact period limit for proper sound. Fix redundancies in wiring_pwmExtend Servo to map in-use pins, Tone already has this.
dok-net
changed the title
dok-net
changed the title
earlephilhower
approved these changes
Apr 17, 2020
devyte
reviewed
Apr 17, 2020
| @@ -49,7 +52,7 @@ void tone(uint8_t _pin, unsigned int frequency, unsigned long duration) { | |||
| if (frequency == 0) { | |||
| noTone(_pin); | |||
| } else { | |||
| uint32_t period = (1000000L * system_get_cpu_freq()) / frequency; | |||
| uint32_t period = microsecondsToClockCycles(1000000UL) / frequency; | |||
There was a problem hiding this comment.
I'm not sure whether this change is ok. The microsecondsToClockCycles() define uses the F_CPU macro, while system_get_cpu_freq() is the SDK api call.
I think it is ok because these functions aren't supposed to be called from an ISR. Also, if built for 160MHz, execution will be done at that speed something like 95% of the time.
devyte
approved these changes
Apr 17, 2020
d-a-v
changed the title
d-a-v
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future-proofing #7122, newly introduced public
startWaveformCycles()is more aptly namedstartWaveformClockCycles()(like in rest of core API for this type of use).Fix/clarify comments.
Fix redundancies in Tone, end Tone waveform on exact period limit for proper sound.
Fix redundancies in wiring_pwm.
Extend Servo to map in-use pins, Tone already has this.