Fix reverse dependency core Updater -> library ESP8266WiFi #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@earlephilhower The unnamed namespace is C++ for internal linkage, |
earlephilhower
requested changes
Aug 16, 2019
There was a problem hiding this comment.
Very minor comments, but OTW looks good to me. @devyte, can you give this a look-see?
| @@ -20,6 +20,7 @@ | |||
| Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | |||
| */ | |||
|
|
|||
| #include "BearSSLHelpers.h" | |||
There was a problem hiding this comment.
Why the move of this include before the others?
There was a problem hiding this comment.
I use this idiom as good practice to ensure that headers are self contained - I don't want other people having to find out the hard way that some header dependencies must be manually resolved each time.
earlephilhower
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per review comments from @earlephilhower, see #6393 (comment) ff.