Remove dependency to rt-crates #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
remove-unnecessary-dependencies
branch
from
f014229 to
1fbcfef
Compare
|
Is the |
|
It's unfortunately required and used in the generated code |
|
Ahh too bad, just checking 😁 |
jessebraham
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change for what was discussed in esp-rs/esp-hal#382
For Xtensa it still needs
xtensa-lxbut that is less of a problem since it changes not that frequently. Would be better to not need it but that's how svd2rust generates the code currently. (I don't think we need that in our HALs but not a big deal IMHO)