Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haptic Feedback Configuration (on settings page) #9

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

finger563
Copy link
Contributor

Description

  • Update squareline gui to have panel in settings screen for haptic setting - showing current setting with +/- buttons to change it and a play button to try it out.
  • Update GUI component to have functional interface to set haptic waveform and play the currently configured haptic waveform.
  • Minor bugfix to enum in drv2605 component.
  • Updated layout of settings panel to remove extra padding on edges / top and add padding between the individual settings.

Motivation and Context

  • Allows easier testing / customization of haptic feedback

How has this been tested?

Running it on the emu box.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

image

Design:
CleanShot 2022-11-29 at 10 35 36

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…e haptic setting with play button for testing it out.
@finger563 finger563 merged commit 0ca5bac into main Nov 29, 2022
@finger563 finger563 deleted the feature/haptic-configuration branch November 29, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant