Mute and Video Scaling buttons #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
finger563
commented
Nov 15, 2022
finger563
commented
- Added GPIO config for mute button (IO1) and boot button (IO0), with interrupt sending button to task
- Updated UI to allow for querying / setting the video scaling
- Updated UI to break apart mute from volume setting
- Updated NES video loop to properly handle dynamic changes to video scaling
- Updated GB/C video loop to properly handle dynamic changes to video scaling
- Removed offset configuration from display when starting emulators to make it easier to configure / clear when changing video scaling.
… button (boot used for video scaling toggle). now gameboy and nes can handle changing the scaling of the video output while they are running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.