Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/automatic save states #11

Merged
merged 7 commits into from
Jan 2, 2023
Merged

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 14, 2022

Description

  • Automatically generate save state names for NES and GB/GBC roms
  • Automatically load / save states when starting/stopping emulation
  • Clean up gb/c emulator codebase a little - removing some things that aren't used
  • Update GB/C video task to have a timeout on the xqueuepeek - allowing the task to be stopped and started so that it's not always running (not that it would matter if it were...)
  • Update submodule

Motivation and Context

  • Saving progress makes emulation fun

⚠️ NOTE:
It appears not all uSD cards work - I have one (8 GB Kingston) which i can load roms / images from just fine, but I cannot write save states to. However, I have another one (32 GB Samsung) which i can write save states to just fine (no change in configuration).
⚠️

How has this been tested?

  • Pokemon Yellow (GB)
  • Link's Awakening DX (GBC)
  • Super Mario Bros. (NES)

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

box_emu_savestates_compressed.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 merged commit 6f57c18 into main Jan 2, 2023
@finger563 finger563 deleted the feature/automatic-save-states branch January 2, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant