Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mdns): Added mDNS for finding rtsp stream #4

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Updated espp submodule
  • Added esp-protocols submodule for mdns component
  • Updated main code to use mdns component to find an RTSP server on the network and use the found ip address and port number when connecting to the RTSP server.

Motivation and Context

Related Camera Streamer PR: esp-cpp/camera-streamer#4

This PR enables the camera display to automatically find and connect to an RTSP display on the network which is advertising over mDNS (like the new camera-streamer does. This means that you no longer have to hardcode the address or host name into your app.

How has this been tested?

Building and running on an ESP-S3-BOX.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated espp submodule
* Added esp-protocols submodule for mdns component
* Updated main code to use mdns component to find an RTSP server on the network and use the found ip address and port number when connecting to the RTSP server.
@finger563 finger563 added enhancement New feature or request mDNS labels Aug 9, 2023
@finger563 finger563 merged commit 91d9e11 into main Aug 9, 2023
@finger563 finger563 deleted the feature/mDNS branch August 9, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mDNS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant