db: Data API timestamp conversion #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
approved these changes
Feb 24, 2025
canepat
added
erigon3
battlmonstr
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
I'd either call the file ts_range_from_kv.cpp, or move it to api/endpoint/timestamp.cpp and move api::Timestamp and TimestampRange from common.hpp there.
There was a problem hiding this comment.
I'll take your first suggestion (renaming the file) and in the meantime improve the naming from ts_range_from_kv to as_datastore_ts_range, since the function is already in namespace db::kv::api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.