capi: execute single transaction #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch/silkworm into capi-execute-single-txn
|
Also see erigontech/silkworm-go#13 for the related silkworm-go update |
battlmonstr
requested changes
Jan 30, 2025
| @@ -53,6 +53,8 @@ struct SilkwormInstance { | |||
| std::unique_ptr<silkworm::rpc::Daemon> rpcdaemon; | |||
| std::unique_ptr<silkworm::stagedsync::ExecutionEngine> execution_engine; | |||
|
|
|||
| std::optional<silkworm::ChainConfig> chain_config; | |||
There was a problem hiding this comment.
We also have this field inside instance.node_settings.chain_config.
I have on my TODO list to split it to be separate from NodeSettings, because we believe that NodeSettings should just only reflect static CLI options.
So even if duplicate - it is a change in a good direction :)
battlmonstr
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds execution of a single transaction to be called externally (Erigon 3).
MDBX was updated to v0.38.4, in line with Erigon 3.
Minor modifications made to the domain data access, no prev_step is necessary. Please take a look at the breakdown below of how data is stored in Erigon 3, also in the Erigon 3 book:
Account:
Code (has_large_values):
Storage: