evm: drop bailout option from validate_call_funds() #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bailout option to validate_call_funds() makes it no-op function. Drop this option from the function so that the transaction validation code is not aware of the bailout semantic. Instead, ignore the validation result in the single place where it matters.
yperbasis
approved these changes
Jan 13, 2025
chfast
commented
Jan 13, 2025
| if (const auto result = protocol::validate_call_funds(txn, evm, owned_funds, bailout); | ||
| result != ValidationResult::kOk) { | ||
| if (const auto result = protocol::validate_call_funds(txn, evm, owned_funds); | ||
| !bailout && result != ValidationResult::kOk) { |
There was a problem hiding this comment.
The application is a big awkward because we call the function even if we don't need the result. But considering the bailout is not enabled often this somehow guarantees the validate_call_funds still work correctly without crashes or assert failures.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2652 +/- ##
=======================================
Coverage 50.63% 50.63%
=======================================
Files 784 784
Lines 52416 52416
Branches 8150 8150
=======================================
Hits 26541 26541
Misses 23553 23553
Partials 2322 2322 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bailout option to validate_call_funds() makes it no-op function. Drop this option from the function so that the transaction validation code is not aware of the bailout semantic. Instead, ignore the validation result in the single place where it matters.